Skip to content

Adds rowsAffected and insertID, also cleanup codebase #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Aug 3, 2022
Merged

Adds rowsAffected and insertID, also cleanup codebase #17

merged 12 commits into from
Aug 3, 2022

Conversation

iheanyi
Copy link
Contributor

@iheanyi iheanyi commented Aug 3, 2022

This pull request adds some production polish to get us ready for our first release. Here's a list of things that changed.

  • Added rowsAffected and insertId to the ExecutedQuery type.
  • Return the raw error object from the API rather than separating it into two fields
  • Unexported private types
  • Simplified tests
  • Added support for parsing floats

@iheanyi iheanyi requested a review from dgraham August 3, 2022 18:05
dgraham
dgraham approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@dgraham dgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡️

@iheanyi iheanyi merged commit fc77cad into main Aug 3, 2022
@iheanyi iheanyi deleted the iheanyi/various-improvements branch August 3, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgraham dgraham dgraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iheanyi @dgraham